maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.
BSD 3-Clause "New" or "Revised" License
77 stars 34 forks source link

Sodiumoxide tracking policy #47

Closed dbrgn closed 6 years ago

dbrgn commented 7 years ago

Do you have any policy regarding tracking of changes from sodiumoxide?

For example, here is a feature that was recently added to sodiumoxide that I'd like to see in rust_sodium as well.

Do you plan on including sodiumoxide changes into rust_sodium from time to time, or would it be better to create a standalone pull request with the functionality?

Fraser999 commented 6 years ago

We have been periodically pulling changes in from sodiumoxide, but not to any fixed schedule. I hope to get a chance to look at updating again soon, but unless any are critical, this task could get pushed back down the queue unfortunately.

dbrgn commented 6 years ago

Ok, but if that is the plan there's no use in duplicating functionality that's present in sodiumoxide :)

Fraser999 commented 6 years ago

Yes - I try to avoid just duplicating the functionality and actually cherry-pick commits from sodiumoxide (even though they almost always have conflicts and need fixed up) so that the original authors appear in our repo's history.