search

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.
BSD 3-Clause "New" or "Revised" License
77 stars 34 forks source link

Download libsodium sources using reqwest library #51

Closed dbrgn closed 6 years ago

dbrgn commented 6 years ago

Instead of calling out to curl and powershell, we can use a native cross-platform HTTP client instead. This gets rid of a lot of hacky code.

May I ask why there is a fallback URL for the libsodium sources? Makes me a bit uneasy to download the sources for a crypto library in production builds from a third party (although that's fine as long as the signatures are available too).

(This cleanup will make it much easier to implement #45)

dbrgn commented 6 years ago

Rebased against current master.

Fraser999 commented 6 years ago

Hey @dbrgn,

Thanks for this PR - a much cleaner approach indeed :) I'd started down this road myself, but never got time to finish it.

As you've seen, I've rebased this on master and added a couple of minor changes. A final change was to get rid of the fallback URL. We'd had some issues with the libsodium sources being temporarily unavailable from time to time, but I'm not sure it's still a problem. Either way; the fallback URL is gone!

I'll close this now since it's contained within #55. Thanks again!

dbrgn commented 6 years ago

Great, thanks!