Multiple updates - Githubissues

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.

BSD 3-Clause "New" or "Revised" License

77 stars 34 forks source link

Multiple updates #60

Closed Fraser999 closed 6 years ago

Fraser999 commented 6 years ago

This incorporates multiple changes:

use an env var to disable downloading libsodium files rather than a feature
dropped support for rustc-serialize since it has been deprecated
pulled most outstanding sodiumoxide commits downstream (fixes #47)
added a hash check of downloaded libsodium files to build script (fixes #45)

It also includes the contents of #59, so that should be reviewed and merged prior to this.

nshtg commented 6 years ago

Any ETA on this?

Fraser999 commented 6 years ago

@nshtg Unfortunately, it'll be a wee while longer. There was a problem with our AppVeyor script which meant that a test failure on 32-bit Windows was being hidden.

I'm getting an unhandled exception while running the generichash_multipart test. This is only the case on 32-bit Windows using the MinGW version of libsodium 1.0.16.

Once this is resolved, I'll try to get this reviewed and merged ASAP.