search

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.
BSD 3-Clause "New" or "Revised" License
77 stars 34 forks source link

Build requires openssl #78

Closed Aceeri closed 5 years ago

Aceeri commented 6 years ago

Seems that because of the reqwest dependency for building, it also pulls in hyper-tls which uses openssl which is kind of unfortunate.

jacderida commented 5 years ago

83 addresses this.

We discussed on Slack and it was agreed we could resolve based on the fact that we can build with OpenSSL 1.1.1. I verified this on an Ubuntu 14.04 VM: Initial version of openssl:

vagrant@ubuntu-trusty-rust-slave:~/openssl-1.1.1$ openssl version
OpenSSL 1.0.1f 6 Jan 2014

Upgrade as per these instructions (with an additional fix from here):

vagrant@ubuntu-trusty-rust-slave:~$ openssl version
OpenSSL 1.1.1  11 Sep 2018

Run cargo build for rust_sodium:

Compiling rust_sodium-sys v0.10.1 (file:///home/jenkins/rust_sodium/rust_sodium-sys)
warning: unused import: `Read`
  --> rust_sodium-sys/build.rs:21:23
   |
21 | use std::io::{Cursor, Read};
   |                       ^^^^
   |
   = note: #[warn(unused_imports)] on by default

   Compiling rust_sodium v0.10.1 (file:///home/jenkins/rust_sodium)
    Finished dev [unoptimized + debuginfo] target(s) in 2m 26s