search

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.
BSD 3-Clause "New" or "Revised" License
77 stars 34 forks source link

Fail to build on nightly: private_no_mangle_fns, private_no_mangle_statics #90

Closed kpp closed 5 years ago

kpp commented 5 years ago 
humbug@home:~/rust_sodium$ rustup default nightly
info: using existing install for 'nightly-x86_64-unknown-linux-gnu'
info: default toolchain set to 'nightly-x86_64-unknown-linux-gnu'

  nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.32.0-nightly (65204a97d 2018-11-12)

humbug@home:~/rust_sodium$ cargo build
   Compiling rust_sodium-sys v0.10.2 (/home/humbug/rust_sodium/rust_sodium-sys)
error: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported`
  --> rust_sodium-sys/src/lib.rs:11:24
   |
11 |     plugin_as_library, private_no_mangle_fns, private_no_mangle_statics, stable_features,
   |                        ^^^^^^^^^^^^^^^^^^^^^
   |
note: lint level defined here
  --> rust_sodium-sys/src/lib.rs:7:90
   |
7  |     exceeding_bitshifts, mutable_transmutes, no_mangle_const_items, unknown_crate_types, warnings
   |                                                                                          ^^^^^^^^
   = note: #[forbid(renamed_and_removed_lints)] implied by #[forbid(warnings)]

error: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported`
  --> rust_sodium-sys/src/lib.rs:11:47
   |
11 |     plugin_as_library, private_no_mangle_fns, private_no_mangle_statics, stable_features,
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `rust_sodium-sys`.

To learn more, run the command again with --verbose.
humbug@home:~/rust_sodium$ rustc -vV
rustc 1.32.0-nightly (65204a97d 2018-11-12)
binary: rustc
commit-hash: 65204a97d4876b897df0a70c0b9248b57e2bf057
commit-date: 2018-11-12
host: x86_64-unknown-linux-gnu
release: 1.32.0-nightly
LLVM version: 8.0
pierrechevalier83 commented 5 years ago

Thanks for reporting, @kpp. Fixed in https://github.com/maidsafe/rust_sodium/pull/92