search

maidsafe / rust_sodium

This crate is no longer maintained. Looking for maintainers.
BSD 3-Clause "New" or "Revised" License
77 stars 34 forks source link

Fix build on rust 1.31.0 #91

Closed winding-lines closed 5 years ago

winding-lines commented 5 years ago

Building on rust 1.31.0 fails with errors like

error: lint private_no_mangle_fns has been removed: no longer an warning, #[no_mangle] functions always exported

This PR removes the lint.

winding-lines commented 5 years ago

Note that this PR is a tiny subset of https://github.com/maidsafe/rust_sodium/pull/92.

pierrechevalier83 commented 5 years ago

Hi @winding-lines, thanks for your contribution. Sorry I didn't notice it before raising PR 92 (I was tackling the Maidsafe crates systematically). Part of your PR is indeed covered by PR 92, but what about updating lazy_static? Was there a reason in particular you wanted this change in?

winding-lines commented 5 years ago

Thanks for your reply! My app loads both this crate and tantivy (text search). The latest tantivy dependencies bump requires a new lazy_static.

Marius

On Jan 2, 2019, at 3:22 AM, Pierre Chevalier notifications@github.com wrote:

Hi @winding-lines, thanks for your contribution. Sorry I didn't notice it before raising PR 92 (I was tackling the Maidsafe crates systematically). Part of your PR is indeed covered by PR 92, but what about updating lazy_static? Was there a reason in particular you wanted this change in?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

pierrechevalier83 commented 5 years ago

If you want to rebase your PR and only keep the lazy_static update, I'll review it for you and merge it once CI passes :smile:

naturallymitchell commented 5 years ago

aside:

My app loads both this crate and tantivy

can I see?

pierrechevalier83 commented 5 years ago

I raised a separate PR just to update lazy_static: https://github.com/maidsafe/rust_sodium/pull/95. Closing this one.