fix (sn_cli): Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs

willief commented 1 month ago

fix: Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs

Description

Existing error message referred to "files upload" This changes the error to refer to "files download"

Related Issue

Fixes #1890

Type of Change

Please mark the types of changes made in this pull request.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

[x] I have read the contributing guidelines.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have updated the documentation accordingly.
[x] I have followed the conventional commits guidelines for commit messages.
[ ] I have verified my commit messages with commitlint.

joshuef commented 1 month ago

Thanks for this @willief . For simplicity i've made https://github.com/maidsafe/safe_network/pull/1893 which adds the title you have (almost perfect commit convention) to the commit msg.

That should now pass the CI checks therein

(note the lack of sentence case and no space before subject, ie fix(cli) not fix (cli))

willief commented 1 month ago

Thanks Joshuef, there was more work in the commit message than in the issue itself :-)

On Sat, 15 Jun 2024 at 23:19, joshuef @.***> wrote:

Thanks for this @willief https://github.com/willief . For simplicity i've made #1893 https://github.com/maidsafe/safe_network/pull/1893 which adds the title you have (almost perfect commit convention) to the commit msg.

That should now pass the CI checks therein

(note the lack of sentence case and no space before subject, ie fix(cli) not fix (cli))

— Reply to this email directly, view it on GitHub https://github.com/maidsafe/safe_network/pull/1892#issuecomment-2170944598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHW3IKQICDUPH5CJKIBPTZHS4YXAVCNFSM6AAAAABJKTE3KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZQHE2DINJZHA . You are receiving this because you were mentioned.Message ID: @.***>

-- Regards Willie Fleming

maidsafe / safe_network