maidsafe / safe_network

72 stars 40 forks source link

[Network] Filter out private addresses #1994

Closed mickvandijke closed 2 weeks ago

mickvandijke commented 1 month ago

When looking at the logs here https://maidsafe.slack.com/archives/C07BC38RH6U/ we can see a lot of MultiaddrNotSupported("/ip4/192.168.88.1 . This is a private address and the other peers should not have this as thier external address. We have a filter multiaddr_is_global that would prevent that, but something is off.

– As reported by @RolandSherwin

RolandSherwin commented 2 weeks ago

Fixed with https://github.com/maidsafe/safe_network/pull/2044