search

maidsafe / safe_network

72 stars 40 forks source link

[Launchpad] Allow user to specify node install path #1998

Open mickvandijke opened 1 month ago

mickvandijke commented 1 month ago

Currently, nodes are installed on the default drive of the machine. This is not necessarily how users wish to operate the node (given machines with secondary drives) This task is to allow users to specify the drive which the nodes operate from

@joshuef i presume this would be done first on node-manager, and need a second task for launchpad?

– As reported by @Nic-dorman

mickvandijke commented 1 month ago

The node install path can already be set through safenode-manager --data-dir-path <NODE_INSTALL_PATH>. Just need to update the launchpad to also support changing the node install directory.

mazzi commented 1 month ago

What is the default state of the storage location? The default one per platform.

What will happen if the user changes the location and we already have data on it? Stop the nodes and restart in a new location? Should a prompt exits for the user?

mickvandijke commented 1 month ago

My idea was to add an optional root install directory path input at the bottom of the "Manage Nodes" window. If a path is set, then any NEW node would be installed to that root path. Existing nodes would not move to the new install directory, unless done manually.

mazzi commented 1 month ago

Good one, but managing two paths may be difficult. If the user changes again the path, will be another one to manage. Nevertheless, another approach is going to be considered in terms of UI.