search

maidsafe / safe_network

Autonomi combines the spare capacity of everyday devices to form a new, autonomous, data and communications layer of the Internet
http://autonomi.com
81 stars 51 forks source link

Feature(CLI): Return file addresses within archive when uploading a directory #2434

Open traktion opened 3 days ago

traktion commented 3 days ago

I understand that files are now collated within an archive. I assume there are reasons for this (perhaps performance or cost oriented?), but it is making the upload/download process more difficult in some cases.

However, when an directory is uploaded (as an archive), only the archive address (XOR) is returned. This makes it hard to know how to directly address the files, unless each are uploaded separately. This assumes that directly addressing the files isn't an issue?

Can the CLI return a list of addresses for each item in the archive, along with the archive address itself? Also, can autonomi file list do the same?

happybeing commented 3 days ago

I agree that this is a problem and have a PR in progress which splits this API into two functions.

One does as now, but is renamed dir_and_archive_upload() and the new function dir_upload() no longer uploads the Archive but returns it so the caller can inspect the content (files uploaded and xor address). This avoids uploading the Archive unnecessarily, which been be done separately if required.

@traktion how about that?