search

maidsafe / safenetwork.tech

BSD 3-Clause "New" or "Revised" License
18 stars 22 forks source link

Convert main navigation bar #164

Closed shankarsengalani closed 5 years ago

shankarsengalani commented 5 years ago

Convert the main navigation bar as a React component to adapt all the breakpoints of v1.1 design. Use CSS Grid system to design its layout. Also integrate it with existing pages of the website..

S-Coyle commented 5 years ago

@shankar2105 not quite sure what to test this against - can you add a link to the design I should be comparing to? Thanks

Note - discussed this further with @JimCollinson to try to get a better understanding and go through the changes, but ended up with some more qns. Jim will follow up with Shankar before it comes back to QA for review

calumcraig commented 5 years ago

Failed QA - https://github.com/maidsafe/safenetwork.tech/issues/191

Returned story to in progress.

calumcraig commented 5 years ago

Test results / notes can be found in this spreadsheet:

https://docs.google.com/spreadsheets/d/1nemlM-lmzGVVWXaT_8U4SY0940BiySBWeMR9uQSaUgc/edit#gid=0

Now that the Get involved issue has been resolved #191 this story is OK to pass QA - moving to done.