search

maidsafe / safenetwork.tech

BSD 3-Clause "New" or "Revised" License
18 stars 22 forks source link

Pointer icon does not change to finger when hovering over hamburger icon. #190

Closed calumcraig closed 5 years ago

calumcraig commented 5 years ago

Steps to reproduce:

  1. Resize browser window so that main navigation bar elements change to a hamburger menu.
  2. Hover mouser pointer over hamburger icon.

Expected result: Pointer icon changes to finger icon (as when hovering over a hyperlink). Actual result: Icon does not change: image

Found testing PR #170

calumcraig commented 5 years ago

This behaviour is also the case when the hamburger menu is expanded and the pointer hovers over the X to close it: image

calumcraig commented 5 years ago

A (presumably) related issue can be seen (only) in Firefox. When clicking the hamburger icon or the X to close the menu, a dotted line around the edge of the icon can be seen: image image

calumcraig commented 5 years ago

Retested this against https://github.com/shankar2105/safenetwork.tech/tree/navBar_v_1_1 built locally.

Now working as expected.

Not able to provide screenshots as they capture the pointer in default form.

Closing issue and moving to done.

calumcraig commented 5 years ago

Related issue https://github.com/maidsafe/safenetwork.tech/issues/190#issuecomment-470525381 is still seen to persist - will raise this as an independent issue as the fix hasn't resolved that.

Raised this - #195.

calumcraig commented 5 years ago

Tested against https://naughty-cray-61a71b.netlify.com/.

Working as expected now - mouse pointer does indeed change to a finger icon when hovering over the hamburger icon (when screen is resized for this to display). Not posting a screenshot as only the normal pointer is captured but this has been verified on both Chrome and Firefox.

calumcraig commented 5 years ago

Fixed by PR #170 - moving to QA Verified.