search

maidsafe / self_encryption

file self encryptor
Other
118 stars 70 forks source link

Refactor unsigned integer types #315

Closed kanav99 closed 3 years ago

kanav99 commented 3 years ago

I am still unsure about the implications in the cross-platform scenario. According to me, there should be no problem as the encryption function calls and types are unchanged, so the output should not be different for any architecture. But @dirvine says that there are special ramifications we need to be sure of. But I went ahead and changed everything to usize and see what happens. If there are certain issues, we can specifically cast them there. But overall, the code looks much more cleaner with no explicit type casts everywhere.

lionel-faber commented 3 years ago

The changes look good @kanav99 Nice one! There's one more thing that's needed in this PR. Could you please add BREAKING CHANGE to any of the commit messages. So the message would be like:

refactor(module): what was done:

BREAKING CHANGE: what the breaking change is
kanav99 commented 3 years ago

Yes, the second commit has these breaking tag!

lionel-faber commented 3 years ago

Ah nice one! Sorry I didn't notice it