Idea for future PR, I think we can clean up the build return value here if build returns a dbc_builder
let (reissue_tx, dbc_builder, _material) = tx_builder.build(&mut rng8)?;
We could go further and return a ReissueRequestBuilder instead of the reissue_tx and then expose an API ReissueRequestBuilder::inputs_missing_spentproofs() to iterate inputs that are missing spentproofs.
This way the builders chain into each other more seamlessly.
We can do this design study after this PR goes in, it's big enough already :laughing:
dan-da
commented
2 years ago
Idea for future PR, I think we can clean up the build return value here if build returns a dbc_builder
We could go further and return a
ReissueRequestBuilderinstead of thereissue_txand then expose an APIReissueRequestBuilder::inputs_missing_spentproofs()to iterate inputs that are missing spentproofs.This way the builders chain into each other more seamlessly. We can do this design study after this PR goes in, it's big enough already :laughing:
_Originally posted by @davidrusu in https://github.com/maidsafe/sn_dbc/pull/121#discussion_r805176837_