fix: change BTreeSet<SpentProofShare> to HashSet - Githubissues

maidsafe / sn_dbc

Safe Network DBCs

BSD 3-Clause "New" or "Revised" License

15 stars 16 forks source link

fix: change BTreeSet<SpentProofShare> to HashSet #136

Closed dan-da closed 2 years ago

dan-da commented 2 years ago

bug: The ReissueRequestBuilder was only storing 1 SpentProofShare per KeyImage because the SpentProofShare were being ordered by KeyImage which is the same for all items in the set for a given input.

The fix is to use a HashSet instead.

changes:

use HashSet instead of BTreeSet in ReissueRequestBuilder
add NodeSignature::to_bytes()
impl (PartialEq, Eq) manually on SpentProofShare
remove Ord, PartialOrd impls on SpentProofShare
impl Hash on SpentProofShare
add SpentProofShare::to_bytes()