maidsafe / sn_dbc

Safe Network DBCs
BSD 3-Clause "New" or "Revised" License
15 stars 16 forks source link

integrate blsttc/blstrs and remove mint::* #157

Closed dan-da closed 2 years ago

dan-da commented 2 years ago

This PR includes and obsoletes #154. removes 827 LOC. :+1:

Alternatively, if #154 were merged as-is, I could rebase this branch to include only the mint removal.


integrate blsttc/blstrs

highlights:

lowlights:


remove mint::*

feat: remove mint nodes and related data structures

We realized that mint nodes no longer serve a useful purpose as the spentbook nodes now both verify and sign the transaction.

By removing the mint nodes:

  1. The client has less work to do.
  2. Safe network elder nodes need only have a single role and do less work.
  3. we remove a bunch of code from sn_dbc, making remaining code easier to learn/audit/maintain.
  4. the system becomes more flexible as a spentbook can be anything that can generate a SpentProof.