search

maidsafe / sn_dbc

Safe Network DBCs
BSD 3-Clause "New" or "Revised" License
15 stars 16 forks source link

refactor(signing): impl async for signer trait #50

Closed oetyng closed 3 years ago

oetyng commented 3 years ago

This is because downstream consumer dependency implements async methods returning result, for signing.

dan-da commented 3 years ago

This PR is titled "use signer trait instead of secret key share". But it is now introducing async.

I'd prefer to see them separated into 2 distinct PRs if possible...?

oetyng commented 3 years ago

This PR is titled "use signer trait instead of secret key share". But it is now introducing async.

I'd prefer to see them separated into 2 distinct PRs if possible...?

Sure, first one is here: https://github.com/maidsafe/sn_dbc/pull/51

(will rebase this one and mark as ready when the above is in)

oetyng commented 3 years ago

Superseded by #61