maidsafe / sn_nodejs

BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

Invalid native/Cargo.toml file #71

Open Thierry61 opened 4 years ago

Thierry61 commented 4 years ago

Describe the bug Dependencies in native/Cargo.toml are not coherent, though those in native/Cargo.lock compile fine. This prevents anyone forking the repo to modify the dependencies because in this case native/Cargo.lock needs to be regenerated.

To Reproduce Steps to reproduce the behavior:

  1. Clone the repo
  2. Go to native sub-directory
  3. cargo update
  4. cargo build
  5. See error

Expected behavior No error should be generated

Screenshots

$ cargo update
    Updating git repository `https://github.com/geovie/neon`
    Updating crates.io index
    Updating git repository `https://github.com/bochaco/neon-serde`
$ cargo build
   Compiling safe-nodejs v0.11.0 (/home/ubuntu0/Documents/safe/tmp/safe-nodejs-maidsafe/native)
error[E0433]: failed to resolve: use of undeclared type or module `EventHandler`
    --> src/lib.rs:1173:22
     |
1173 |             let cb = EventHandler::new(js_callback);
     |                      ^^^^^^^^^^^^ use of undeclared type or module `EventHandler`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: could not compile `safe-nodejs`.

To learn more, run the command again with --verbose.

Desktop OS: [Ubuntu 18.04.1] Shell: [bash] Rust: [1.43.1 stable] safe-nodejs version [e.g. 0.11.5]