Closed patt0 closed 9 years ago
Except for the two minor non-critical inline-comments I made this looks great! :+1:
Thanks!
https://github.com/maiera/gde-app/issues/54 can be closed
Sounds/looks good to me, feel free to merge and close whenever you deploy this into production :)
Disabling writes, taking a backup and uploading the code, reenable writes -> All Done
The implementation is different in that we only merge AP is they are actual shares from another post, if they are not we will create a new AR and leave it to the GDE to decide how and why he merges AR's and their associated AP's. In order to do this, I process the new activities from oldest to newest.
The implementation is pretty much the same as previously. In particular we continue to ignore the fact that a #gde tag is removed from a gplus post, we consider currently that it has to be deleted in the front end, to be discussed at the summit.
@Scarygami thanks for having a good look at this :)