search

maiera / gde-app

Apache License 2.0
22 stars 9 forks source link

Iss99 Implementation #185

Closed SmokyBob closed 9 years ago

SmokyBob commented 9 years ago

Front End implementation of #99 (and #182 ) Wait for final testing after #184 is deployed on firefly and production

SmokyBob commented 9 years ago

Note to self: Add a dialog after delete is clicked to ask if the user want to Trash or Delete (for good) the activity.

Add a filter on top of the activity table to quickly filter the activities by status (Active, Trash, All)

SmokyBob commented 9 years ago

Live version pointing to firefly is up here (almost... still uploading 654 files :( )

Scarygami commented 9 years ago

Works nicely.

But don't you think it would be better to request the full list (includeDeleted=true) by default, and then do the filtering on the frontend only, instead of doing a full request each time the checkbox is clicked?

SmokyBob commented 9 years ago

:+1: as soon as I've pushed the changes on Drive I thought about changing that... New commit in a bit

SmokyBob commented 9 years ago

Updated the code for my statistics, tomorrow (today...) I'll try to replicate the same logic on the Googlers Access (this way I can sneak in part of #188 :) )

Scarygami commented 9 years ago

Small issue with trashing/untrashing:

  1. Trash activity
  2. Enable checkbox to inlcude trashed activities.
  3. The trashed activity isn't there.

Only way to untrash a trashed activity is to refresh the page.

SmokyBob commented 9 years ago

fixed and deployed on the test site. P.S. Thx for the test

Scarygami commented 9 years ago

Works as intended now :+1: