maiera / gde-app

Apache License 2.0
22 stars 9 forks source link

Add raw_impact Charts and Tables #189

Closed SmokyBob closed 9 years ago

SmokyBob commented 9 years ago

As requested during the GDE app sync call of 2014-12-11 before the total_impact, show the raw_impact. The raw_impact is the sum of the data to calculate the total_impact but without the logarithmic functions applied.

SmokyBob commented 9 years ago

As discussed in #190 a new column meta_impact will be added to charts and tables , 'social_impact' will sum the current 3 columns plusones, reshares and comments and will be displayed instead.

SmokyBob commented 9 years ago

PR #193 implement the changes. Live Demo

patt0 commented 9 years ago

I think we need to mention the total impact, but still display it as a log maybe????

The graphs become meaningless with this value I think.

Patrick Martinent

On 4 February 2015 at 02:33, Mauro Solcia notifications@github.com wrote:

Closed #189 https://github.com/maiera/gde-app/issues/189.

— Reply to this email directly or view it on GitHub https://github.com/maiera/gde-app/issues/189#event-229571081.

SmokyBob commented 9 years ago

@patt0 do you mean remove the Total Impact from the charts or show the Log(x) of metadata and social impact because otherwise the values of those two tends to be so big to make the total_impact invisible?

patt0 commented 9 years ago

Yes I think we can make the visualisation much more interesting by having two scales, one linear for which values such as activities logged and total impact ( calc value ) will be ploted and on the other axix have a log scale against which we can plot meta_impact and social_impact

Patrick Martinent

On 11 February 2015 at 00:41, Mauro Solcia notifications@github.com wrote:

@patt0 https://github.com/patt0 do you mean remove the Total Impact from the charts or show the Log(x) of metadata and social impact because otherwise the values of those two tends to be so big to make the total_impact invisible?

— Reply to this email directly or view it on GitHub https://github.com/maiera/gde-app/issues/189#issuecomment-73762539.

SmokyBob commented 9 years ago

Deployed Test version on staging but the staging api on firefly seems to not return raw metadata columns. We can discuss if the new charts looks good (and other chart additions) during tomorrow's meeting (if needed I can switch the code to use the prod api in the staging site briefly to see meaningful data)

patt0 commented 9 years ago

I am in Malaysia this week ... I will try to make the call. Yes its possible the latest code has not been pushed to staging.

I'll try to get connected, check and push in a couple of hours.

Best

patt0 commented 9 years ago

I have updated the data from omega to firefly and we now get some values in RAW, looks nice but I dont think they are correct tough.

I also pushed the latest code to firefly.

Patrick Martinent

On 18 February 2015 at 04:04, Patrick Martinent <patrick.martinent@gmail.com

wrote:

I am in Malaysia this week ... I will try to make the call. Yes its possible the latest code has not been pushed to staging.

I'll try to get connected, check and push in a couple of hours.

Best

SmokyBob commented 9 years ago

... I should stop deploying things at night... I've fixed the code in the source code and run the build job, but the staging site is still responding with the old code... I'll check later.

On Wed Feb 18 2015 at 2:02:33 AM Patrick Martinent notifications@github.com wrote:

I have updated the data from omega to firefly and we now get some values in RAW, looks nice but I dont think they are correct tough.

I also pushed the latest code to firefly.

Patrick Martinent

On 18 February 2015 at 04:04, Patrick Martinent < patrick.martinent@gmail.com

wrote:

I am in Malaysia this week ... I will try to make the call. Yes its possible the latest code has not been pushed to staging.

I'll try to get connected, check and push in a couple of hours.

Best

— Reply to this email directly or view it on GitHub https://github.com/maiera/gde-app/issues/189#issuecomment-74790540.