Closed freeqaz closed 7 years ago
Hi there!
I have no idea how to link acorn as a dependency so I can do import acorn
, this caused the third_party
folder in the root and the clunky build.js
file. I'd love to get rid of all this!
Sadly iroh is already a registered package name, so I decided to use irohjs
for now - maybe the author of it is willed to transfer ownership.
I recently added a basic test to intercept require
calls in theory here, so required code would get tracked too and can get linked to the main stage. However I'm not sure if that's the way to go or to let the user explicitly decide which code to track.
Update: the package author was so kind to transfer the ownership, iroh can now be used
Added node.js support with https://github.com/maierfelix/Iroh/commit/f42f96a37de09f3d26c8047843ab2ef0f5b17a38
npm install iroh
should now work
Sweet, thank you for getting this sorted out!
This library is awesome and I've started experimenting with how I can use this to build some dynamic analysis tools. My goal is to trace through requests in an Express app, which is all Node.
Currently, there are some shortcomings that prevent using this library in Node. There is an
npm
module published, though it seems to be outdated. Thepackage.json
also is missing an index path that allows arequire
statement to grab the code.To fix this, something along the following lines should be done (which I might drop a PR for):
npm install
andimport Iroh from 'irohjs';
acorn
is installed as adependency
inpackage.json
and also imported via Node syntaximport acorn from 'acorn';
fs
to grab the raw source code and then operate on that.As I said, I might drop a PR to fix these. Wanted to highlight them before I sit down and foster a discussion. Let me know if you have any questions for me!