search

maierfelix / webgpu

WebGPU for Node [Deprecated, Unmaintained]
MIT License
244 stars 17 forks source link

GPUShaderModule has new Dawn Error. #21

Closed dcerisano closed 4 years ago

dcerisano commented 4 years ago

Just a headsup, I compile against the official Dawn build, and there are recent changes there affecting your webgpu-napi. You won't see these until you rebase your dawn-ray-tracing repo.

Error is:

../src/GPUShaderModule.cpp:23:14: error: no member named 'code' in 'WGPUShaderModuleDescriptor'
  descriptor.code = nullptr;
  ~~~~~~~~~~ ^
../src/GPUShaderModule.cpp:24:14: error: no member named 'codeSize' in 'WGPUShaderModuleDescriptor'
  descriptor.codeSize = 0;
  ~~~~~~~~~~ ^
2 errors generated.

Related to this upstream Dawn change.

Local Fix:

Removed code and codeSize initializers (line 23 and 24).

maierfelix commented 4 years ago

The next dawn upstream change will be somewhat big and I didn't start on it yet.

maierfelix commented 4 years ago

Fixed by https://github.com/maierfelix/webgpu/commit/c1151a1c27d707798bf70906972f557935b3203a