search

maiflai / gradle-scalatest

A plugin to enable the use of scalatest in a gradle Scala project.
The Unlicense
73 stars 35 forks source link

Plugin is incompatible with Gradle 7 #92

Closed dubinsky closed 3 years ago

dubinsky commented 3 years ago

ScalaTestAction calls org/gradle/process/internal/DefaultExecActionFactory.root() with null for gradleUserHome; this is no longer supported starting with Gradle 7 (commit with the change).

Also, the method called is deprecated; the comment says:

Do not use this. It's here because some of the services this type needs are not easily accessed in certain cases and will be removed ay some point. Use one of the other methods instead

DanySK commented 3 years ago

The problem seems to be here: https://github.com/maiflai/gradle-scalatest/blob/5920f79fd6e1ec5cc6793f881e23cca0ee953ac8/src/main/groovy/com/github/maiflai/ScalaTestAction.groovy#L69

maiflai commented 3 years ago

Yes, I'm trying to work out how to update this without having to rewrite all the tests.

dubinsky commented 3 years ago

Yes, I'm trying to work out how to update this without having to rewrite all the tests.

Thank you!

josecsotomorales commented 3 years ago

Just got this issue when updating my project to Gradle 7.0, glad that you folks are already tracking it!

Habitats commented 3 years ago

Any update on this? 🙏

maiflai commented 3 years ago

I've uploaded 0.31 with a partial fix (it still uses a deprecated api).

Please could you take a look?

dubinsky commented 3 years ago

@maiflai yay! it works!!! thanks!

josecsotomorales commented 3 years ago

@maiflai it's working! thanks! 🚀

dpsoft commented 3 years ago

@maiflai works like a charm!! thanks!

Habitats commented 3 years ago

works like a charm indeed!

thanks for fixing! :D

maiflai commented 3 years ago

thanks folks.