search

maiflai / gradle-scalatest

A plugin to enable the use of scalatest in a gradle Scala project.
The Unlicense
73 stars 35 forks source link

Version 0.31 is not properly published #94

Closed chali closed 3 years ago

chali commented 3 years ago

Hello, we noticed that project using dynamic version for this plugin started failing.

Declared dependency on plugin classpath 'com.github.maiflai:gradle-scalatest:0.+' Project build fails with: Plugin with id 'com.github.maiflai.scalatest' not found.

I did a bit of searching and is likely related to the way how publishing is configured. Here are the published artifacts https://repo1.maven.org/maven2/com/github/maiflai/gradle-scalatest/0.31/ There are no jars just pom files.

I believe that after build file refactoring you are missing from components.java More about it the docs

One unrelated note. Moving the plugin to Gradle 7 will very likely make it incompatible for existing users who are still using Gradle 6.+. Gradle 7 will use Groovy 3 for plugin compilation and classes compiled with Groovy 3 are not working with Groovy 2 in older Gradle versions. Maybe you should consider bumping a major version.

maiflai commented 3 years ago

Thanks - I've published the missing files, please could you check again? Sorry for the mistake.

The versions here don't follow semver as such - they are simply releases. The recent changes have been for forwards-compatibility rather than backwards.

chali commented 3 years ago

Thank you for the fix!

If a plugin is released with Gradle 6 it can be compatible with both Gradle 6.x and 7.x but if it using Gradle 7 it will be very likely only compatible with Gradle 7.x. It depends on what Groovy features are used.

It is a better user experience when you don't have to upgrade Gradle and plugins at the same time.

maiflai commented 3 years ago

thanks, will bear that in mind.