search

maik / xml-simple

Easy API for working with XML documents
MIT License
88 stars 27 forks source link

Added 'AttrToSymbol' option; other changes #13

Closed runnerpack closed 10 years ago

runnerpack commented 10 years ago

Hi, Maik, I only recently found XmlSimple, and so far I love it! It only needed a few tiny changes, hence this pull request.

To go with the KeyToSymbol option, I added an AttrToSymbol option. I also renamed xmlsimple.rb to xml-simple.rb, since it was confusing to me that the require'd file didn't match the gem name. I also updated some of the documentation (I didn't do anything to the RDoc, since I didn't change the API).

Let me know if you want anything changed before you pull (assuming you want to at all). BTW, sorry about the "master branch" thing. This is my first pull request, and I'm not very experienced with git as a whole (I'm not even sure what a "topic branch" is, much less how to make one :P ).

-Amos

runnerpack commented 10 years ago

Argh! I just noticed that I didn't update the version number or the date in the gemspec :disappointed:

maik commented 10 years ago

Hi Amos!

Your fixes look great and I'll integrate them soon. Thank you very much!

Best, Maik

runnerpack commented 10 years ago

Thanks, Maik! :smile: