search

maikerumine / mobs_mc

MC like mobs from many authors. This should be complete when released.
GNU General Public License v3.0
22 stars 9 forks source link

Death animation is randomly repeating for many mobs #11

Closed Wuzzy2 closed 7 years ago

Wuzzy2 commented 7 years ago

The death animation is randomly repeating for many mobs, for example, the skeleton.

maikerumine commented 7 years ago

I think this is in the mobs_redo code, as this has happened in earlier versions of this mod when I was using blockmens zombies. sadly, i couldn't fix without changing the api, and that gets old when ten keeps changing the api. Keeping dependancy to mobs_redo should come to an end I think, to better preserve the integrity of this mod. I cannot tell you how many times I rewrote my mobs api to "merge" his updates and removal of code. LOL

Wuzzy2 commented 7 years ago

I am strongly opposed to combining mob API with mobs themselves. Those must be strictly kept separate IMO. The mob situation in the modding community is already terrible enough. Why not just informing TenPlus1 about the Mobs Redo bugs instead, or even better: File a PR?

22i commented 7 years ago

@maikerumine @Wuzzy2 mobs redo has been updated recently with animation flag for looping

https://github.com/tenplus1/mobs_redo/issues/67 write this in the animation table die_loop = false near die_start and die_end

Wuzzy2 commented 7 years ago

@22i: Sorry, just adding die_loop = false doesn't do the trick. Tested with evoker and fresh Mobs Redo. I think the animation speed, start and stop frame need to be fixed as well, as explained by TenPlus1 in https://github.com/tenplus1/mobs_redo/issues/67.

You seem to be the perfect person to fix this, as you are most familiar with your own models.

Wuzzy2 commented 7 years ago

It turns out it was a Mobs Redo bug. When updating Mobs Redo now, all death animations are now finally working.