search

maikvandergaag / msft-extensions

Repository for extensions mainly used for Azure DevOps Extensions
https://msftplayground.com
MIT License
126 stars 81 forks source link

Update SQL Credentials - Scope parameter #501

Closed kevinn1992 closed 4 months ago

kevinn1992 commented 10 months ago

Describe the issue In the Power BI Action Update SQL Credentials there's a scope parameter which has the 2 values "Individual" and "Organization". If I'm not mistaken, this is the privacy level you give to your credentials like 'public', 'organizational' and 'private'. I refer to the official documentation: https://learn.microsoft.com/en-us/rest/api/power-bi/gateways/update-datasource#definitions

When I look at your code for the new Power BI Actions right here: https://github.com/maikvandergaag/msft-extensions/tree/main/azuredevops/powerbiactions-new/powerbiactionsnew/ps_modules/PowerBi for the function 'Update-BasicSQLDataSourceCredentials' (check the image below), it seems that the parameter 'Individual' is not correct. image image

Isn't it the intention to give the 3 different privacy levels: 'public', 'organizational' and 'private' as parameter and change your function to some kind of switch?

Now, no matter what you fill in into your scope the $level variable will always be 'Individual' which is not a privacy level. Please, correct me if I'm wrong.

Kind regards

maikvandergaag commented 10 months ago

@kevinn1992: Hi Kevin, you seem to be right here. There was a explicit choice why we used the Individual one when we created the extension.

At this moment we are actively working on a XPlat version of the task will try to incorporate this stuff into the development.

kevinn1992 commented 10 months ago

Perfect! Thanks for the quick response!

maikvandergaag commented 10 months ago

@kevinn1992: when you are open to help with testing that would be much appriciated. I'm not a Power BI specialist and created the extension pure out of passion.

maikvandergaag commented 9 months ago

Still working on the xplat version. Would be able to incorporate it. Are you maybe able to help testing?