maikvandergaag / msft-extensions

Repository for extensions mainly used for Azure DevOps Extensions
https://msftplayground.com
MIT License
125 stars 80 forks source link

Added support to set SQL datasource credentials to a Service Principal #536

Closed yorickbouma closed 8 months ago

yorickbouma commented 8 months ago

Recently, support for Service Principals for certain data sources has been added. You can read more about it here.

One of the significant use cases for this feature is with Datasets that derive their data from Synapse Serverless using Import. Currently, we've manually configured Service Principals for this purpose, but now it's also possible to set these Service Principal credentials via the API.

This PR introduces support for setting the credentials of a SQL datasource of a dataset to a Service Principal. Here's what's included:

Please let me know if any additional information or testing is required. We're keen to beta-test this feature.

yorickbouma commented 8 months ago

@maikvandergaag feel free to reach out if you have any questions regarding the recent change. If there are any additional requirements or if you need assistance with testing, don't hesitate to let me know.

maikvandergaag commented 8 months ago

@yorickbouma : do you already have access to the beta? And would you also be able to test xplat version?

yorickbouma commented 8 months ago

@maikvandergaag Yes, I do. I see that an update was pushed yesterday, but unfortunately, I couldn't spot the new action on either the "normal" or "xplat" versions. image image image

I could conduct some testing with the xplat version, but unfortunately, I can not test the complete extension. We've installed the development extension on a sandbox Organization since I won't get it cleared to get it installed on the Organization we use for our actual environment due to the dev nature of the version.

Additionally, I've noticed that there are two xplat versions, and both of them create a DEV - Power BI Actions@6 task. image

yorickbouma commented 8 months ago

@maikvandergaag https://github.com/maikvandergaag/msft-extensions/pull/538

maikvandergaag commented 8 months ago

Yes sorry the deployment of the beta extension was stuck due to an error. Fixed that so there should be a new beta version.

maikvandergaag commented 8 months ago

Version 5.4.54

yorickbouma commented 7 months ago

@maikvandergaag, the new task functionality is working as expected on our sandbox environment. However, it seems that XPLAT does not have this new feature. As mentioned before, I'm unable to conduct extensive XPLAT testing on our sandbox environment. Would it be safe to push the @6 to the production version of the task without disrupting @5? This would allow me to thoroughly test the XPLAT version on our complete setup on @6.

maikvandergaag commented 7 months ago

Hi Yorrick,

We can push the regular version to production. The xplat one is a totally different one so the functionality needs to be added there as well. I even have to add your organization to the Beta if you want to test is.

From: yorickbouma @.> Sent: Friday, 22 March 2024 13:00 To: maikvandergaag/msft-extensions @.> Cc: Maik van der Gaag @.>; Mention @.> Subject: Re: [maikvandergaag/msft-extensions] Added support to set SQL datasource credentials to a Service Principal (PR #536)

@maikvandergaaghttps://github.com/maikvandergaag, the new task functionality is working as expected on our sandbox environment. However, it seems that XPLAT does not have this new feature. As mentioned before, I'm unable to conduct extensive XPLAT testing on our sandbox environment. Would it be safe to push the @6https://github.com/6 to the production version of the task without disrupting @5https://github.com/5? This would allow me to thoroughly test the XPLAT version on our complete setup on @6https://github.com/6.

— Reply to this email directly, view it on GitHubhttps://github.com/maikvandergaag/msft-extensions/pull/536#issuecomment-2014930377, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACIXAE4CVGEY2ME4KWSH5T3YZQMLFAVCNFSM6AAAAABE5ILWBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJUHEZTAMZXG4. You are receiving this because you were mentioned.Message ID: @.**@.>>

yorickbouma commented 7 months ago

@maikvandergaag That's clear, thank you. Unfortunately, I won't be able to assist with testing the XPLAT version in that case.

yorickbouma commented 7 months ago

@maikvandergaag, do you require any further assistance from me to transition to the production version, or should I just sit back and wait for the update to roll out?

maikvandergaag commented 7 months ago

Did you test the function and does it work as expected?

If yes then I will schedule the production deployment.

yorickbouma commented 7 months ago

@maikvandergaag yes, perhaps I wasn't clear, but I tested it on our sandbox environment, and it worked as expected.

maikvandergaag commented 7 months ago

Great I will setup the prod deployment

maikvandergaag commented 7 months ago

Just, started give it about 10 till 20 min