mail-in-a-box / mailinabox

Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.

https://mailinabox.email/

Creative Commons Zero v1.0 Universal

13.98k stars 1.44k forks source link

Typo in setup/ssl.sh #1566

Open alento-group opened 5 years ago

alento-group commented 5 years ago

Install openssl.

apt_install openssl

Should be apt install openssl no?

ctrl-i commented 5 years ago

You have probably already discovered this but just in case you haven't, see here: https://github.com/mail-in-a-box/mailinabox/blob/25fec63a03be972c8989eeada1ca09b9d7b7ae50/setup/functions.sh#L50

There is a function defined as apt_install in the setup/functions.sh that is used to make the output of "apt install" quieter so in this case it should not be "apt install openssl" unless you want a more verbose output when installing.

alento-group commented 5 years ago

You have probably already discovered this but just in case you haven't

Nope. Hadn't seen that, and hadn't looked either.

I had to reinstall LE and the original ssl keys, so ran this script. Or attempted to ... it encountered an error at the line I mentioned. Ignorant of scripting, I believed it to be an issue of a typo since I wasn't aware of the 'functions'. Sadly, I cannot see the actual error in my terminal window to provide more information ...