search

mail-in-a-box / mailinabox

Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.
https://mailinabox.email/
Creative Commons Zero v1.0 Universal
13.96k stars 1.44k forks source link

allow axfr ip to be in subnet format in secondary dns config #1615

Open kimusan opened 5 years ago

kimusan commented 5 years ago

My DNS provider requires the server to be open for a subnet segment for axfr requests. So basically I would have to input an address line xxx.xxx.xxx.0/28 instead of xxx.xxx.xxx.xxx in the input field for secondary DNS config. Unfortunately this is not allowed by MIAB (NSD supports it just fine). Would it be possible to change to ip address check to also allow subnet segment addresses like the one mentioned here? It would make it a lot easier for me to add new domains as I do not have to go in and change the zones.conf manually every time.

JoshData commented 5 years ago

I'd be happy to merge a pull request that makes that change.

On July 28, 2019 11:47:17 PM GMT+03:00, Kim Schulz notifications@github.com wrote:

My DNS provider requires the server to be open for a subnet segment for axfr requests. So basically I would have to input an address line xxx.xxx.xxx.0/28 instead of xxx.xxx.xxx.xxx in the input field for secondary DNS config. Unfortunately this is not allowed by MIAB (NSD supports it just fine). Would it be possible to change to ip address check to also allow subnet segment addresses like the one mentioned here? It would make it a lot easier for me to add new domains as I do not have to go in and change the zones.conf manually every time.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/mail-in-a-box/mailinabox/issues/1615

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

kimusan commented 5 years ago

I'll see if I can find a bit of time to fix it.

kimusan commented 5 years ago

I think this should do the job: https://github.com/mail-in-a-box/mailinabox/pull/1616 I do not have a test setup to test it as I currently only have a production server running MIAB and there are too many active users for me to mess around.

alento-group commented 5 years ago

I think this should do the job:

1616

I do not have a test setup to test it as I currently only have a production server running MIAB and there are too many active users for me to mess around.

If you need to test, reach out to me as I have test MiaB installs that can be used.

kimusan commented 5 years ago

Thank you. You are very welcome to test the patch and see that it accepts both xxx.xxx.xxx.xxx op addresses and xxx.xxx.xxx.0/28 (or similar) subnet addresses