search

mailchain / mailchain-legacy

Using Mailchain, blockchain users can now send and receive rich-media HTML messages with attachments via a blockchain address.
https://mailchain.xyz
Apache License 2.0
143 stars 51 forks source link

thats an arbitrary limit #48

Open todo[bot] opened 5 years ago

todo[bot] commented 5 years ago

https://github.com/mailchain/mailchain/blob/caee741f1fb1d9aa408804940e80bf70739fbd1b/internal/pkg/http/rest/ethereum/address/messages/get.go#L80-L85

This issue was generated by todo based on a TODO comment in caee741f1fb1d9aa408804940e80bf70739fbd1b when #46 was merged. cc @robdefeo.
stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

robdefeo commented 5 years ago

This size of this page is intended to retrieve the most recent transactions which MAY contain messages. It is possible that there are no messages in the most recent but there are messages that are on the next page from the response. Having a limit prevents a solution that is durable for at least this scenario

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please reply in order to keep the issue open. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

todo[bot] commented 3 years ago

This issue has been reopened because the TODO comment still exists in cmd/mailchain/internal/http/handlers/messages.go, as of 1372d29cc88ae6fffe1511ddf4f6263580e5c205.

If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.
todo[bot] commented 3 years ago

This issue has been reopened because the TODO comment still exists in cmd/mailchain/internal/http/handlers/messages.go, as of f85c09ea74722525db86ce90aac433a9e729af6f.

If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.