search

mailchimp / mc-woocommerce

MailChimp for Woocommerce Integration. Syncs all data (subscriber, customers, orders, products) and enables marketing automation with email campaigns, automations, ads, postcards and more.
https://wordpress.org/plugins/mailchimp-for-woocommerce/
GNU General Public License v2.0
82 stars 66 forks source link

Add validation for Name #59

Closed lduh closed 7 years ago

lduh commented 7 years ago

Wasn't initially included, since the Name is pre-populated. But if it's deleted, we run into the same behaviour where it says settings are saved, but they are not.

ryanhungate commented 7 years ago

@lduh sorry what tab are we talking about on this one?

lduh commented 7 years ago

Store settings!

ryanhungate commented 7 years ago

@lduh what error do you want to flash on this one when they try to remove the store name?

lduh commented 7 years ago

I think they can remove it and change it, but they shouldn't be able to submit with it blank (like address or phone)

ryanhungate commented 7 years ago

@lduh yeah totally get that... so what are we going to have the error message be when they try to make it blank?

lduh commented 7 years ago

MailChimp for WooCommerce requires a Store Name to connect your store.

lduh commented 7 years ago

looks good: https://cl.ly/3q3Q2V230p3T

lduh commented 7 years ago

adding validation to make sure it's not whitespace