mailchimp / wordpress

Add a Mailchimp signup form widget to your WordPress site.
https://wordpress.org/plugins/mailchimp/
GNU General Public License v2.0
1 stars 0 forks source link

Do not SSR in legacy themes #38

Closed nateconley closed 5 months ago

nateconley commented 5 months ago

Description of the Change

Disallows legacy themes from server side render in the block editor. These older themes do not have the full stylesheet enabled in the block editor and will instead apply core's forms.css for admin forms.

Closes #2

How to test the Change

Changelog Entry

Enhances: new block

Credits

@nateconley

Checklist:

nateconley commented 5 months ago

@dkotter To address your concerns on Twenty Twenty-Four, here is what Contact Form 7 looks like:

Screenshot 2024-06-27 at 6 29 13 AM

I think the best path forward here might be to add field "Padding" and "Button" settings to the "Custom Styling" section - I can add that in.

For the denylist, I think this is going to be difficult to accomplish consistently, as we really don't have a reliable way to figure out how much of the theme style is added to the editor.

dkotter commented 5 months ago

@nateconley Sorry, just saw your message as I was working on this. I've added in some basic padding to all form elements and things look much better to me now with the ability to still easily override that on a theme level:

Adjusted form styles

Though feel free to adjust further if needed

nateconley commented 5 months ago

@dkotter If this is working well across themes, I think this is a great path forward. Thanks!

nateconley commented 5 months ago

@dkotter I gave this a quick look in themes 2024, 2023, 2022, and 2021 and it looks great!