search

mailchuck / PyBitmessage

This repository has been discontinued, please use the official PyBitmessage repository
https://github.com/Bitmessage/PyBitmessage
MIT License
28 stars 4 forks source link

Windows binary requires msvcr120.dll #173

Closed PeterSurda closed 8 years ago

PeterSurda commented 8 years ago

I got a report that on XP, it reports that msvcr120.dll is missing. Probably becuase the build environment has a newer MSVS installed.

ghost commented 8 years ago

What about compiling with MinGW instead? That might solve the problem.

PeterSurda commented 8 years ago

MinGW causes different issues, for example it causes UPX-ed binary to crash. I can look at it some other time to make sure it works for MinwGW too but it's not a priority.

I had to recompile python and some other stuff, and one of those things wouldn't build with MSVS 2008, so I installed 2012 and this introduced this bug. The solution is easy, I just have to bundle the dll in the spec file. But the report came after 0.5.7 was released and it didn't trigger on my windows test machine, it probably had the dll from somewhere else.

PeterSurda commented 8 years ago

Fixed in cf09872d67667d992caaec6fc60d6b5182498e01