Closed comfuzio closed 1 year ago
Ok problem solved by running apt install whois, but how did this got removed? or wasn't used by update.sh in the first place and now after the selfupdate it needs it?
It wasn't required by the update.sh in the first place. This requirement was introduced with this commit: https://github.com/mailcow/mailcow-dockerized/commit/815572f2009e7964599de20e2d9e9e177bf15a27
I've now added this requirement to the Release Notes.
Thank you very much @FreddleSpl0it ! I can close this now :)
I am running on Unraid and I am not able to install whois. So is there any way that this change will maybe reverted?
If you have http://ipv4.mailcow.email
to get the requested IP, couldn't you also make an endpoint that returns whois -h whois.radb.net $(curl -s http://ipv4.mailcow.email)
(the ASN)?
If you have
http://ipv4.mailcow.email
to get the requested IP, couldn't you also make an endpoint that returnswhois -h whois.radb.net $(curl -s http://ipv4.mailcow.email)
(the ASN)?
Good point! Didn't thought about that. I'll see what we can do in this way!
And my request would be to have the update.sh (and generate conf also uses whois) to not fail "Cannot find..." but rather state a disclaimer that this check was unsuccessful and a user promt if the user wants to proceed (as good ASN 'mode')/ should check manually for the ASN of their IP. Something like that, if you get my idea.
But thank you already for considering an endpoint for the ASN.
Done!
Can you run the update.sh again?
Maybe you have to do git fetch && git checkout update.sh origin/master first as it is still awaiting whois until you downloaded the new update.sh
git fetch && git checkout origin/master -- update.sh
did it. Thanks. Issue fixed for me.
I am impressed with how fast you solve issues guys :) Shall I close is the issue?
Before I do, can i ask about "On June 20th, Spamhaus blocked access to these lists from OVH, AWS, and Hetzner servers.", my server is a vm in hetzner but in Finland, where would I see the "to see if you’re affected. If you are, mailcow will notify you." where would I see the notify? I have spend some time in the mailcow's gui but didn't see any notification related to that. Does it affect all Hetzner's servers or some?
ah ok it is the: "./update.sh Detecting if your IP is listed on Spamhaus Bad ASN List... Check completed! Your IP is clean"
Does it affect all Hetzner's servers or some?
Hetzner is not affected at all. I messed that up, sorry. AWS, OVH and Cloudflare are affected by now.
Contribution guidelines
I've found a bug and checked that ...
Description
Logs:
Steps to reproduce:
Which branch are you using?
master
Operating System:
Ubuntu 22.04.2 LTS
Server/VM specifications:
12 cpu cores, 8gb ram, 100gb storage but 20gb used
Is Apparmor, SELinux or similar active?
if it is by default, haven't changed it
Virtualization technology:
KVM, Proxmox 8.0.3
Docker version:
Docker version 24.0.5, build ced0996
docker-compose version or docker compose version:
Docker Compose version v2.20.2
mailcow version:
2023-05
Reverse proxy:
default that comes with docker install
Logs of git diff:
Logs of iptables -L -vn:
Logs of ip6tables -L -vn:
Logs of iptables -L -vn -t nat:
Logs of ip6tables -L -vn -t nat:
DNS check: