mailcow / mailcow-dockerized

mailcow: dockerized - 🐮 + 🐋 = 💕
https://mailcow.email
GNU General Public License v3.0
8.26k stars 1.12k forks source link

Add switch to skip fetching certificates auto{config,discover} subdomains #5838

Closed schichtnudelauflauf closed 3 weeks ago

schichtnudelauflauf commented 2 months ago

Add switch to skip fetching certs for auto{config,discover} subdomains.

Might be useful in certain reverse proxy situations.

This is a cleaned up version of https://github.com/mailcow/mailcow-dockerized/pull/5474

The things discussed there are changed and I made a better name. I had to open a new PR due to Github Web UI limitations.

The old PR that is linked can bre closed.

@jennypaxian, pinging you too because you'll not be auto notified.

schichtnudelauflauf commented 2 months ago

(Offtopic: How much I hate that the webinterface does sign my commits with a key I don't control. I'd rather they were unsigned. Sheesh.)

dragoangel commented 2 months ago

You feel that variable definitely is too long?

AUTODISCOVER_SAN=y/n and should be y by default in compose when unset. Don't want autodiscover, put it to n

schichtnudelauflauf commented 2 months ago

that sounds kinda ambiguous but I'll put it if it gets it merged 😁

jennypaxian commented 2 months ago

You feel that variable definitely is too long?

AUTODISCOVER_SAN=y/n and should be y by default in compose when unset. Don't want autodiscover, put it to n

Sounds good to me, also thanks y'all for following up on it.

schichtnudelauflauf commented 2 months ago

Ok now after snail fast editing of things on my phone the name is changed, default flipped.

dragoangel commented 2 months ago

Well now it looks cleaner for me, thanks.

schichtnudelauflauf commented 2 months ago

Just in case, I couldn't squash the commits together with the webinterface from the phone. I have no laptop nearby. But you'll merge squashed anyways ig?

schichtnudelauflauf commented 1 month ago

Can I get a yes or no here?