search

mailcow / mailcow-dockerized

mailcow: dockerized - 🐮 + 🐋 = 💕
https://mailcow.email
GNU General Public License v3.0
8.25k stars 1.12k forks source link

Allow hard-coding IPV4 and IPV6 rather than it being detected #5895

Open cmer opened 3 weeks ago

cmer commented 3 weeks ago

This allows hardcoding IPV4 and IPV6 rather than being automatically detected when renewing SSL certificates.

This is handy in scenarios where outbound traffic comes from a different IP than what would normally be expected.

milkmaker commented 3 weeks ago

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging. See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

cmer commented 3 weeks ago

They are environment variables. If not set (this is the default), the IP is automatically resolved. Otherwise, if set, it uses the hardcoded IP in the environment variables.

dragoangel commented 2 weeks ago

What is the purpose of this change? What are you trying to solve? If you using SNAT properly this should be never the case. Seems to me like a dirty attempt to fix wrong network configuration. For very broken setups there is already option to skip ip check.