mailcow / mailcow-dockerized

mailcow: dockerized - 🐮 + 🐋 = 💕
https://mailcow.email
GNU General Public License v3.0
8.25k stars 1.12k forks source link

Docker v27: Native IPv6 NAT implementation no longer experimental #5921

Open mrclschstr opened 6 days ago

mrclschstr commented 6 days ago

Summary

Since Docker v27, ip6tables are no longer experimental and are also active by default. See: https://docs.docker.com/engine/release-notes/27.0/#ipv6

Accordingly, a shortened daemon.json could look like this (source: https://docs.docker.com/config/daemon/ipv6/#use-ipv6-for-the-default-bridge-network):

{
  "ipv6": true,
  "fixed-cidr-v6": "2001:db8:1::/64"
}

Unfortunately, the update.sh script checks the existence of the configurations experimental: true and ip6tables: true and aborts with an error if these are not found in the daemon.json configuration. See: https://github.com/mailcow/mailcow-dockerized/blob/master/update.sh#L103

Motivation

Perhaps the check could be improved so that the configurations with Docker version >=27 no longer have to be present? Currently, however, their presence has no disadvantages.

Additional context

No response

DerLinkman commented 6 days ago

Hi,

that's actually a good point.

Will write that down and build in such check for the next patch.