search

mailerlite / mailerlite-nodejs

MIT License
32 stars 7 forks source link

fix: groups on subscribers are full group objects #44

Closed TobbenTM closed 6 months ago

TobbenTM commented 7 months ago

Resolves #35 and #36.

Mantas97 commented 6 months ago

Thanks for contributing @TobbenTM. However, I have to close PR. This won't solve https://github.com/mailerlite/mailerlite-nodejs/issues/35 nor https://github.com/mailerlite/mailerlite-nodejs/issues/36. And groups param in CreateOrUpdateSubscriberParams has to be an array of ids docs

TobbenTM commented 6 months ago

Okay, do you have any intention to fix this yourself @Mantas97 , or do I need to maintain my own functioning fork?

Mantas97 commented 6 months ago

@TobbenTM Mentioned issues are not isolated to SDK, they stem from API. A fix for this is planned for the near future.

Mantas97 commented 6 months ago

@TobbenTM Fixes for #35 & #36 released in 1.2.2

TobbenTM commented 6 months ago

@TobbenTM Fixes for #35 & #36 released in 1.2.2

Thanks for letting me know!