search

mailgun / flanker

Python email address and Mime parsing library
http://www.mailgun.com
Apache License 2.0
1.63k stars 204 forks source link

Pin tld package to maintain py2 support #235

Open bradchiappetta opened 4 years ago

bradchiappetta commented 4 years ago

In order to maintain py2 support tld needs to be pinned : tld==0.10 https://github.com/barseghyanartur/tld/releases

mailgun-ci commented 4 years ago

Can one of the admins verify this patch?

punkrokk commented 4 years ago

@horkhe this PR pins tld==0.10 (the last version that supports py2) can you merge or let me know what else is needed to merge?

horkhe commented 4 years ago

I do not think it makes sense to pin tld in the library, for python3 users may not be happy about it. If the library is used by a Python2 application it is application's responsibility to install relevant tld version. That is what we do.

punkrokk commented 4 years ago

Ok. So are you saying you no longer support python2? I could make an alternate approach where it pins it for Py2 installs, but not py3. I understand your point but it’s gonna cause problems for py2 users.

Your read me at the moment even says use py3 at your own risk

Cheers,

JP

On Dec 11, 2019, at 1:14 AM, Maxim Vladimirskiy notifications@github.com wrote:

 I do not think it makes sense to pin tld in the library, for python3 users may not be happy about it. If the library is used by a Python2 application it is applications responsibility to install relevant tld version. That is what we do.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

horkhe commented 4 years ago

I am not saying that we do not support python 2. I am saying it is your application responsibility to pin versions. Each our python application has requirements.txt file where all dependency versions are pinned. I recommend you to do the same. Pinning version here will immediately cause issues if another your dependency pins to another tld version.