mailgun / flanker

Python email address and Mime parsing library
http://www.mailgun.com
Apache License 2.0
1.63k stars 204 forks source link

Replace deprecated imghdr, switch to stable email.mime API #265

Open salty-horse opened 9 months ago

salty-horse commented 9 months ago

The upcoming Python 3.13 will remove the built-in module imghdr.

Its mimetype-sniffing functionality was copied into email.mime, so I switched to it in flanker/mime/message/part.py.

The same file also uses email.mime.audio._whatsnd, but since it's an internal underscore-prefixed function, it's not part of the stable API and was renamed in Python 3.11.

Instead of using email.mime.audio._whatsnd/_what and imghdr/email.mime.image._what, I think it's safer to use the stable wrapper classes MIMEAudio, MIMEImage, even though they require a bit more work to extract the sniffed content type.

If you disagree, I can switch back to using the internal function.

I tested this with Python 3.10 - please test with 2.7.

BTW, another deprecated module is cgi, which webob uses, but there's an open issue about it upstream, and I'm waiting to see if they intend to release a new version.