Run benchmarks! - Githubissues

mailgun / gubernator

High Performance Rate Limiting MicroService and Library

Apache License 2.0

964 stars 99 forks source link

Run benchmarks! #199

Closed miparnisari closed 11 months ago

miparnisari commented 1 year ago

There are benchmarks written

But they aren't being run anywhere with go test -bench 😱

Suggestion:

Add a bench Make target
On every push to main, run benchmarks and save them
On every commit to a PR, run benchmarks and compare them against main, and alert if they get 2x worse.

I have a demo repo that has the above: https://github.com/miparnisari/benchtest that you can use as reference. I'm happy to send a PR, if you like the idea.