search

mailgun / gubernator

High Performance Rate Limiting MicroService and Library
Apache License 2.0
964 stars 99 forks source link

test benchmark alert #204

Closed miparnisari closed 11 months ago

miparnisari commented 11 months ago

Do https://github.com/mailgun/gubernator/pull/200#issuecomment-1822887904

miparnisari commented 11 months ago
image image
thrawn01 commented 11 months ago

Is there a way to have this report as a warning, and not a failure?

miparnisari commented 11 months ago

@thrawn01 it's possible to leave a comment next to the commit. But in my experience, this is not visible enough, it's very easy to miss. I strongly suggest failing the step if the benchmark gets 2x worse.