mailgun / gubernator

High Performance Rate Limiting MicroService and Library
Apache License 2.0
964 stars 99 forks source link

More unit tests needed + Upload code coverage to CodeCov #215

Open miparnisari opened 9 months ago

miparnisari commented 9 months ago

make test in master currently reports 49.0% code coverage overall. There are multiple critical code paths not covered with tests. For example:

It would be nice if, going forward, we block PRs that do not include tests. I suggest enabling Codecov through https://github.com/marketplace/codecov and uploading code coverage in every PR and for every push to main.

For example: https://github.com/openfga/openfga/blob/164963facc61241e1378d8fefb6632c700407163/.github/workflows/pull_request.yaml#L49-L57

The end goal would be the overall code coverage to a healthier number.

Baliedge commented 8 months ago

I think it would be sufficient to link make test to a GitHub Action that indicates a threshold as a warning, though would be best not to enforce it for now.

Some quick searches revealed:

This would be a welcome addition to the repo.