search

mailgun / gubernator

High Performance Rate Limiting MicroService and Library
Apache License 2.0
964 stars 99 forks source link

fix: goroutine leaks #221

Closed miparnisari closed 8 months ago

miparnisari commented 8 months ago

Gubernator has some goroutine leaks stemming from not properly closing resources. These leaks are not many. However, any software that uses gubernator and that wants to assert that it has 0 leaks will get leaks coming from gubernator 😅

Baliedge commented 8 months ago

@miparnisari Not sure if you've noticed. There's still a failing test that seems relevant to your changes.

miparnisari commented 8 months ago

@Baliedge please see https://github.com/mailgun/gubernator/pull/223 for those failures

Baliedge commented 8 months ago

@miparnisari You'll need to fix a merge conflict, then I'll merge.