`holster/errors` now works with latest golang error introspection

mailgun / holster

A place to keep useful golang functions and small libraries

Apache License 2.0

289 stars 35 forks source link

`holster/errors` now works with latest golang error introspection #160

Closed thrawn01 closed 1 year ago

thrawn01 commented 1 year ago

Purpose

holster/errors now works with errors.Is() and errors.As() and errors.Wrap() from 1.19
Removed dependency on github.com/pkg/errors
Disabled a test that has a race condition in it
Updated holster to V5 and deprecated error.Wrap() and error.Wrapf()
Moved error.Frame and error.StackTrace to callstack package.
Removed some unused types (searched cs.github.com)
Removed .Cause() which was introduced by github.com/pkg/errors and is not used
Updated retry package errors to support new style errors

vtopc commented 1 year ago

We have a few pending breaking changes for v5 - https://github.com/mailgun/holster/search?q=TODO%28v5%29 Could you include them or merge this PR into some v5 branch to do all those TODOs there? cc @Baliedge
Shouldn't we wait for the https://tip.golang.org/doc/go1.20#errors to be released?

thrawn01 commented 1 year ago

We have a few pending breaking changes for v5 - https://github.com/mailgun/holster/search?q=TODO%28v5%29 Could you include them or merge this PR into some v5 branch to do all those TODOs there? cc @Baliedge

I'm going to close this PR and make a mailgun/errors repo. Forcing everyone who uses holster to keep updating ALL of the packages from /v4 to /v5 every time we make a change is painful.

Shouldn't we wait for the https://tip.golang.org/doc/go1.20#errors to be released?

Those changes look additive, should be simple to add support of them later.