search

mailgun / holster

A place to keep useful golang functions and small libraries
Apache License 2.0
287 stars 35 forks source link

Add AddLink method to DummySpan #192

Closed vikmik closed 4 months ago

vikmik commented 5 months ago

This is only in case you'd rather not merge #191 because of the minimum go version bump.

As it stands, projects with holster as indirect dependency cannot build if they also use otel v1.25.0. See also #189 For example, a project using gubernator and otel 1.25.0 cannot build at the moment, because of this.

OTel added a new function to the Span interface, so this PR is the minimal change that can unblock things. I would prefer #191 to be merged, but either will work.

vikmik commented 5 months ago

@vtopc @Baliedge sorry for the linting mishap - I've updated the PR, could you retrigger the workflows?

vikmik commented 5 months ago

Thanks @vtopc - once this PR is merged it will unblock our project

vtopc commented 4 months ago

Thanks @vtopc - once this PR is merged it will unblock our project

No. Thank you.