search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
774 stars 118 forks source link

Let command line args override provided config #134

Closed totemcaf closed 6 years ago

totemcaf commented 6 years ago

According to the documentation in README.md:

"If some option is both specified in the configuration file and provided as a command line argument, then the command line argument wins."

but the func makeConfig(), in main.go says:

// If a YAML configuration file is provided, then load it and let
// parameters provided on the command line override values on it.

This pull requests allows the command line parameters override the provided config file.

In addition, this behavior is consistent to use it in a Dockerfile, the user can provide a config file for specific parameters and using command line commands to override URLs and ports with environment variables.

mailgun-ci commented 6 years ago

Can one of the admins verify this patch?