search

mailgun / kafka-pixy

gRPC/REST proxy for Kafka
Apache License 2.0
773 stars 118 forks source link

add MaxMessageBytes kafka producer parameter #143

Closed korservick closed 6 years ago

korservick commented 6 years ago

For pushing to kafka messages larger then 1000000 bytes, you need to set this parameter. By default it sets to 1000000 bytes ( https://github.com/Shopify/sarama/blob/master/config.go#L293 )

mailgun-ci commented 6 years ago

Can one of the admins verify this patch?

horkhe commented 6 years ago

Ough, man, do you really need to push messages larger than 10Mb? :-) Anyways, it won't hurt to have this parameter exposed, so we will accept the change. Could you please update default.yaml with the parameter and its description.

korservick commented 6 years ago

By default it is just 1MB (not 10MB). Sometimes we have up to 2.5MB size of message.

horkhe commented 6 years ago

Thank you for your contribution.